RFR: 8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified [v6]
Alexander Matveev
almatvee at openjdk.org
Wed Feb 4 20:36:03 UTC 2026
On Wed, 4 Feb 2026 03:48:23 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> This function is being called 3 times already. I think having platform specific code in it is better, then duplicating:
>>
>> RuntimeImageUtils.getReleaseFilePath(MacBundle.fromPath(cookedRuntime).map(MacBundle::homeDir).orElse(cookedRuntime));
>>
>> I do like idea of using `MacBundle.fromPath()`.
>
> The code that finds the JDK image directory in a random path is a separate function.
> The function that returns a path to the "release" file in the JDK image should take a path to the JDK image directory.
>
> If we need a convenience function that does both things, we should implement it on top of these two functions.
I will just use two function.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2765868489
More information about the core-libs-dev
mailing list