RFR: 8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified [v6]

Alexey Semenyuk asemenyuk at openjdk.org
Wed Feb 4 20:49:45 UTC 2026


On Wed, 4 Feb 2026 20:15:53 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Please add a comment explaining this.
>> We also need a test case where the property value is not enclosed in double quotes.
>> 
>> Makes me wonder: is java.util.Properties the correct choice for reading the "release" file?
>
> I do not see why using `java.util.Properties` to read "release" file is bad idea. "release" file is key-value file. `java.util.Properties` does not remove leading and trailing quotes based on documentation. I updated unit test to cover quoted and unquoted values. Including empty value.

I didn't say it is a bad idea; I questioned the choice of the tool for reading the "release" file. Maybe there is a class specifically targeted for reading this file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2765915035


More information about the core-libs-dev mailing list