RFR: 8376187: [VectorAPI] Define new lane type constants and pass them to intrinsic entries [v7]
Jatin Bhateja
jbhateja at openjdk.org
Thu Feb 5 04:33:33 UTC 2026
On Wed, 4 Feb 2026 18:13:08 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments resolution
>
> src/hotspot/share/prims/vectorSupport.hpp line 141:
>
>> 139:
>> 140: // Values in this enum correspond to the jdk.incubator.vector.LaneType ordinal values.
>> 141: enum LaneType {
>
> Please specify the underlying type of this enum: `enum LaneType : int`. Otherwise, this will not work:
>
> VectorSupport::LaneType vltype = static_cast<VectorSupport::LaneType>(laneType->get_con());
>
> It is because casting an integer to an unscoped enum is UB if `laneType->get_con()` does not fit into the range of the enum values.
Thanks @merykitty , addressed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29481#discussion_r2767032912
More information about the core-libs-dev
mailing list