RFR: 8377355: VectorAPI source generation broken after JDK-8371187
Chen Liang
liach at openjdk.org
Mon Feb 9 22:00:13 UTC 2026
On Fri, 6 Feb 2026 20:33:32 GMT, Varada M <varadam at openjdk.org> wrote:
> Added the missing definition of 'swapIfNeeded' in X-Vector.java.template
>
> JBS : [JDK-8377355](https://bugs.openjdk.org/browse/JDK-8377355)
LGTM, the code is now identical from running the script.
Please wait for another reviewer.
src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template line 5396:
> 5394: }
> 5395:
> 5396: @Override
In `ByteVector` there is a `/*package-private*/` comment between these lines.
This is not in the other files.
Can you either:
1. Remove that redundant comment from ByteVector, or
2. Add it here + in non-ByteVector classes
for consistency?
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29616#pullrequestreview-3773093551
PR Review Comment: https://git.openjdk.org/jdk/pull/29616#discussion_r2777580127
More information about the core-libs-dev
mailing list