RFR: 8363996: Obsolete UseCompressedClassPointers [v5]

[David Holmes]

On Thu, 4 Dec 2025 07:02:08 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/cds/archiveBuilder.cpp line 653:
>> 
>>> 651:       dump_region->allocate(sizeof(address));
>>> 652:     }
>>> 653: #ifdef _LP64
>> 
>> Not obvious this isn't still needed.
>
> That is a small simplification that should have been part of https://bugs.openjdk.org/browse/JDK-8363998. The test
> 
> 
> alignment = nth_bit(ArchiveBuilder::precomputed_narrow_klass_shift());
> 
> 
> can be applied to 32-bit, too. There, precomputed_narrow_klass_shift() is zero.

Okay

>> src/hotspot/share/cds/archiveBuilder.cpp line 1120:
>> 
>>> 1118: };
>>> 1119: 
>>> 1120: #ifdef _LP64
>> 
>> Again not clear why this can be removed.
>
> Same reasoning. 32-bit now also uses narrow Klass pointers, so that code can be made unconditionally compilable.

Okay

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2785855099
PR Review Comment: https://git.openjdk.org/jdk/pull/28366#discussion_r2785855868