RFR: 8377355: VectorAPI source generation broken after JDK-8371187
Jatin Bhateja
jbhateja at openjdk.org
Tue Feb 10 07:09:43 UTC 2026
On Tue, 10 Feb 2026 06:10:26 GMT, Chen Liang <liach at openjdk.org> wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template line 5396:
>>
>>> 5394: }
>>> 5395:
>>> 5396: @Override
>>
>> For sake of uniformity you should add /*package-private*/ comment over newly defined swapIfNeeded method.
>
> I think not having that is fine, the classes already have many package-private method without such a comment.
Sounds reasonable. Not a blocker.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29616#discussion_r2786172501
More information about the core-libs-dev
mailing list