RFR: 8375285: Port fdlibm asinh to Java [v8]
Anton Artemov
aartemov at openjdk.org
Tue Feb 10 09:02:16 UTC 2026
On Tue, 10 Feb 2026 02:03:29 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> @jddarcy What is the purpose of such methods that do not seem to be invoked?
>
>> @jddarcy What is the purpose of such methods that do not seem to be invoked?
>
> I'm a bit confused; they do look to be used in that test file; e.g.
>
> https://github.com/openjdk/jdk/blame/f9ded7f88cce75151cec32d1ef1f9662ea10431a/test/jdk/java/lang/Math/HyperbolicTests.java#L251
>
> ` failures += testSinhCaseWithUlpDiff(testCase[0],`
@jddarcy The concern is methods testing with tolerance, e.g. `testSinhCaseWithTolerance`. That one is never used. Same for `testCoshCaseWithTolerance`, `testTanhCaseWithTolerance`. If they are to be removed, I suggest to make is in a separate cleanup PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2786675697
More information about the core-libs-dev
mailing list