RFR: 8376186: [VectorAPI] Nomenclature change for concrete vector classes [v2]
Jatin Bhateja
jbhateja at openjdk.org
Wed Feb 11 10:42:35 UTC 2026
On Tue, 10 Feb 2026 18:27:10 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment resolution
>
> test/jdk/jdk/incubator/vector/gen-tests.sh line 61:
>
>> 59: args="-K$type -Dtype=$type -DType=$Type -DTYPE=$TYPE"
>> 60:
>> 61: VectorPrefix=$Type
>
> This seems unnecessary - why do we need it?
Removed, thanks!
> test/jdk/jdk/incubator/vector/gen-tests.sh line 127:
>
>> 125: abstractvectortype=${typeprefix}${VectorPrefix}Vector
>> 126: abstractvectorteststype=${typeprefix}${VectorPrefix}VectorTests
>> 127: abstractbitsvectortype=${typeprefix}${VectorPrefixe}Vector
>
> Suggestion:
>
> abstractbitsvectortype=${typeprefix}${VectorPrefix}Vector
>
> But, why is it changed from ${Bitstype}?
Fixed!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2792539485
PR Review Comment: https://git.openjdk.org/jdk/pull/29614#discussion_r2792539345
More information about the core-libs-dev
mailing list