RFR: 8377857: Add since checker test for java.naming module [v2]
Jaikiran Pai
jpai at openjdk.org
Fri Feb 13 11:28:16 UTC 2026
> Can I please get a review of this change which introduces a test to verify the usages of `@since` javadoc tags in the `java.naming` module? This addresses https://bugs.openjdk.org/browse/JDK-8377857.
>
> The `SinceChecker` test utility has been in use for several modules, but wasn't added for java.naming. The commit in this PR adds one for that module.
>
> The `SinceChecker` test utility does not handle the presence of a comma in (for example `@since X, Y`) correctly. The javadoc tag spec for `@since` allows that syntax https://docs.oracle.com/en/java/javase/25/docs/specs/javadoc/doc-comment-spec.html#since. As a workaround, the commit in this PR splits the `@since` on `javax.naming.InitialContext` class into two separate declarations (this too is allowed by the `@since` tag spec). I've verified that the generated javadoc continues to correctly show these values. I have also spoken to Nizar about this issue in SinceChecker and it will be addressed separately.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
remove reference to JNDI 1.1 in InitialContext
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29705/files
- new: https://git.openjdk.org/jdk/pull/29705/files/aeb89dc7..c92b0872
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29705&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29705&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/29705.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29705/head:pull/29705
PR: https://git.openjdk.org/jdk/pull/29705
More information about the core-libs-dev
mailing list