RFR: 8296183: jndiprovider.properties contains properties pointing to non-existing classes [v2]

Jaikiran Pai jpai at openjdk.org
Fri Feb 13 12:14:30 UTC 2026


On Fri, 13 Feb 2026 11:57:31 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add reference to DefaultResponseControlFactory in javadoc
>
> src/java.naming/share/classes/com/sun/jndi/ldap/EntryChangeResponseControl.java line 54:
> 
>> 52:  *
>> 53:  * @see PersistentSearchControl
>> 54:  */
> 
> Not that it matters much, but I see that `DefaultResponseControlFactory` and `PersistentSearchControl` both have an `@see EntryChangeResponseControl` so I'd suggest to replace:
> 
> 
> -  * @see com.sun.jndi.ldap.ctl.ResponseControlFactory ResponseControlFactory
> +  * @see DefaultResponseControlFactory

That's a good point, I've updated the PR accordingly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29712#discussion_r2803888024


More information about the core-libs-dev mailing list