RFR: 8362268: NPE thrown from SASL GSSAPI impl when TLS is used with QOP auth-int against Active Directory [v4]

[Jaikiran Pai]

On Mon, 16 Feb 2026 12:38:24 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Daniel's review - recheck while holding the lock
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - add comment
>>  - copyright years
>>  - alternate fix
>>  - rename test
>>  - 8362268: NPE thrown from SASL GSSAPI impl when  TLS is  used with QOP auth-int against Active Directory
>>  - introduce test
>
> src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java line 550:
> 
>> 548:             }
>> 549: 
>> 550:             lock.lock();
> 
> I believe we should check `ldr.shouldAbandonRequest()` here again, while holding the lock. AFAICS the state is mutated in cleanup() while holding that lock, so we should check it again here once the lock is acquired.

Thank you for catching that. You are right that a recheck is needed when holding the lock. I've updated the PR accordingly. Locally, the tests continue to pass with this change and tier testing in CI is currently in progress.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29638#discussion_r2816729536