RFR: 8376403: Avoid loading ArrayDeque in java.util.zip.ZipFile [v3]

Lance Andersen lancea at openjdk.org
Thu Feb 19 16:11:56 UTC 2026


On Tue, 27 Jan 2026 09:30:19 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Hot on the heals of #29288, this PR replaces `ArrayDeque` with `ArrayList` for the Inflater cache implementation in `ZipFile.CleanableResource`.
>> 
>> With this PR, we change the order of the cache from a LIFO queue to a FIFO stack backed by ArrayList. The order seems unimportant, and has indeed been FIFO in the past when using `java.util.Vector`. Intuitively, it should be better to return the most recently used Inflater.
>> 
>> No tests updated, strict refactoring, `noreg-cleanup`.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove null check of final field istreams which is never null

I think this looks OK, thank you for the clean up Eirik

Please wait for a review from Jai or Alan before integrating

-------------

Marked as reviewed by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29430#pullrequestreview-3826880742


More information about the core-libs-dev mailing list