RFR: 8376403: Avoid loading ArrayDeque in java.util.zip.ZipFile [v4]
Eirik Bjørsnøs
eirbjo at openjdk.org
Fri Feb 20 12:51:12 UTC 2026
> Hot on the heals of #29288, this PR replaces `ArrayDeque` with `ArrayList` for the Inflater cache implementation in `ZipFile.CleanableResource`.
>
> With this PR, we change the order of the cache from a LIFO queue to a FIFO stack backed by ArrayList. The order seems unimportant, and has indeed been FIFO in the past when using `java.util.Vector`. Intuitively, it should be better to return the most recently used Inflater.
>
> No tests updated, strict refactoring, `noreg-cleanup`.
Eirik Bjørsnøs has updated the pull request incrementally with three additional commits since the last revision:
- Add code comment about returning the most recently used Inflater from the cache
- Replace polling-style iteration with simple for loop
- Using add instead of addLast seems more natural for a List
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29430/files
- new: https://git.openjdk.org/jdk/pull/29430/files/388306a7..02de2507
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29430&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29430&range=02-03
Stats: 5 lines in 1 file changed: 1 ins; 1 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/29430.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29430/head:pull/29430
PR: https://git.openjdk.org/jdk/pull/29430
More information about the core-libs-dev
mailing list