RFR: 8376403: Avoid loading ArrayDeque in java.util.zip.ZipFile [v3]

[Jaikiran Pai]

On Tue, 27 Jan 2026 09:30:19 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Hot on the heals of #29288, this PR replaces `ArrayDeque` with `ArrayList` for the Inflater cache implementation in `ZipFile.CleanableResource`.
>> 
>> With this PR, we change the order of the cache from a LIFO queue to a FIFO stack backed by ArrayList. The order seems unimportant, and has indeed been FIFO in the past when using `java.util.Vector`. Intuitively, it should be better to return the most recently used Inflater.
>> 
>> No tests updated, strict refactoring, `noreg-cleanup`.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove null check of final field istreams which is never null

src/java.base/share/classes/java/util/zip/ZipFile.java line 755:

> 753:                     Inflater inf;
> 754:                     while (!inflaters.isEmpty()) {
> 755:                         inflaters.removeLast().end();

I think we should replace this with a trivial:


for (Inflater inf : inflaters) {
    inf.end();
}

for the same reasons as in my previous comment - it makes it trivial to understand without raising the questions about last vs first.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29430#discussion_r2832992318