RFR: 8377992: (zipfs) Align ZipFileSystem END header validation with the ZipFile implementation [v2]
Eirik Bjørsnøs
eirbjo at openjdk.org
Fri Feb 20 17:48:04 UTC 2026
On Fri, 20 Feb 2026 17:30:59 GMT, Lance Andersen <lancea at openjdk.org> wrote:
> Overall looks good. You might get some asks to remove the extra blank lines here and there. I have no strong preference.
Comparing with mainline I don't see I added much blank lines. If there is any particular places you'd like me to trim existing ones, let me know.
> I think the copyright should just be 2026 for these new files but need to confirm
My reasoning here is that while these are new files, they are copies containing intellectual property written in the period 2023-2026. I am by no means a lawyer, but shouldn't these copyright headers reflect the IP contained in the file, not the file history itsef?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29747#issuecomment-3936269239
More information about the core-libs-dev
mailing list