RFR: 8377992: (zipfs) Align ZipFileSystem END header validation with the ZipFile implementation [v2]
Eirik Bjørsnøs
eirbjo at openjdk.org
Fri Feb 20 18:28:56 UTC 2026
On Fri, 20 Feb 2026 18:05:36 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Replace ZipFile reference in clas comment with ZipFileSystem
>> - Remove spurious '*'
>> - Extract test vector setup into ZipUtils class reusable across ZipFile/ZipFileSystem tests
>
> test/jdk/jdk/nio/zipfs/EndOfCenValidation.java line 88:
>
>> 86: public void shouldRejectTooLargeCenSize() throws IOException {
>> 87: int size = MAX_CEN_SIZE + 1;
>> 88:
>
> Another blank line example.
>
> Again, I don't have a strong preference, but I have been asked in some PRs to consider it.
>
> I wouldn't rush to do anything, my comment was more of an fyi
Thanks Lance, I pushed a commit which reduces some of the excessive vertical space.
I kept the line following the jtreg comment section since this seems to be very common and I prefer some separation before the import section.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29747#discussion_r2834538507
More information about the core-libs-dev
mailing list