RFR: 8378111: Migrate java/util/jar tests to JUnit [v2]
Eirik Bjørsnøs
eirbjo at openjdk.org
Fri Feb 20 19:04:18 UTC 2026
On Fri, 20 Feb 2026 18:45:44 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> This PR migrates the java/util/jar tests to use _JUnit_.
>>
>> https://github.com/openjdk/jdk/commit/afe0aeee746bccbbe4bc6c9a8cd2302228ecc2f6 includes changes for _testNG_ based tests.
>> https://github.com/openjdk/jdk/commit/c5a7f75840f96fa77ec3ed7faa713990adb84de6 includes changes for `main` based tests.
>>
>> Before: Framework-based tests: 125 = 125 TestNG + 0 JUnit.
>> After: Framework-based tests: 174 = 0 TestNG + 174 JUnit
>
> Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
>
> - Eirik comments
> - Naoto comment
> - Andrey comments
test/jdk/java/util/jar/TestExtra.java line 29:
> 27: * @summary Test that client-provided data in the extra field is written and
> 28: * read correctly, taking into account the JAR_MAGIC written into the extra
> 29: * field of the first entry of JAR files. Zip file specific.
We have been trying to use uppercase ZIP when refering to files and specifications.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29828#discussion_r2834673333
More information about the core-libs-dev
mailing list