RFR: 8376234: Migrate java/lang/constant tests away from TestNG [v2]

Chen Liang liach at openjdk.org
Mon Feb 23 16:22:53 UTC 2026


On Thu, 12 Feb 2026 13:57:57 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Reviews
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into test/constant-no-testng
>>  - Bugs in migration
>>  - No testng in constant
>
> test/jdk/java/lang/constant/MethodHandleDescTest.java line 113:
> 
>> 111:         testMethodHandleDesc(r);
>> 112: 
>> 113:         assertMHEquals(mh, r.resolveConstantDesc(LOOKUP));
> 
> Swapping the arguments isn't necessary since assertMHEquals is reflexive.
> The method arguments don't follow the junit expected/actual ordering.

I checked again, after the migration, the assertMHEquals behaves effectively as (expected, actual). I have updated the arguments of that code to indicate this intention.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29396#discussion_r2841759945


More information about the core-libs-dev mailing list