RFR: 8374222: jpackage will exit with error if it fails to clean the temp directory [v2]

Alexey Semenyuk asemenyuk at openjdk.org
Wed Feb 25 11:10:08 UTC 2026


On Wed, 18 Feb 2026 01:58:16 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/TempDirectoryTest.java line 123:
> 
>> 121: 
>> 122:     @ParameterizedTest
>> 123:     @CsvSource({"100", "0"})
> 
> Do we need to test other limits like 101 or 1?

Added 101 and 1

> test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/TempDirectoryTest.java line 292:
> 
>> 290: 
>> 291:         boolean isSuccess() {
>> 292:             return this ==  SUCCEED;
> 
> Extra space.

Extra whitespace removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29664#discussion_r2849883356
PR Review Comment: https://git.openjdk.org/jdk/pull/29664#discussion_r2849884476


More information about the core-libs-dev mailing list