RFR: 8378111: Migrate java/util/jar tests to JUnit [v3]
Justin Lu
jlu at openjdk.org
Wed Feb 25 18:01:26 UTC 2026
On Wed, 25 Feb 2026 08:11:41 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> get rid of inheritance + zip -> ZIP
>
> test/jdk/java/util/jar/JarFile/mrjar/MultiReleaseJarHttpProperties.java line 72:
>
>> 70:
>> 71: @BeforeAll
>> 72: public void initialize() throws Exception {
>
> Maybe we should add `static` modifier for @BeforeAll and @AfterAll method
These methods appear like they should be `static` but since this test class uses a `PER_CLASS` lifecycle, these methods are actually fine as instance methods.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29828#discussion_r2854535843
More information about the core-libs-dev
mailing list