RFR: 8373935: Migrate java/lang/invoke tests away from TestNG [v2]

Jorn Vernee jvernee at openjdk.org
Mon Jan 5 16:03:31 UTC 2026


On Wed, 17 Dec 2025 23:51:42 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some omissions
>
> test/jdk/java/lang/invoke/AccessControlTest.java line 217:
> 
>> 215:             boolean sameClass = (c1 == c2);
>> 216:             Assertions.assertTrue(samePackage  || !sameTopLevel);
>> 217:             Assertions.assertTrue(sameTopLevel || !sameClass);
> 
> Suggestion:
> 
>             assertTrue(samePackage  || !sameTopLevel);
>             assertTrue(sameTopLevel || !sameClass);

Looks like you can do this cleanup in other places too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28879#discussion_r2629000475


More information about the core-libs-dev mailing list