RFR: 8374219: Fix issues in jpackage's Executor class [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Wed Jan 7 04:09:53 UTC 2026
On Tue, 6 Jan 2026 03:23:12 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>>
>> test/Executor: minor fix
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgPackager.java line 274:
>
>> 272: .setMaxAttemptsCount(10)
>> 273: .setAttemptTimeoutMillis(3000)
>> 274: .setWriteOutputToFile(true)
>
> Do we always write output to file with new implementation? I see that you call `storeOutputInFiles()` for `hdiutil`.
`storeOutputInFiles()` is applied only to the "hdiutil" command. This is how it was before the patch, and it hasn't changed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28733#discussion_r2666997071
More information about the core-libs-dev
mailing list