RFR: 8373718: jdk/internal/misc/VM/RuntimeArguments.java test fails in Virtual threads mode [v3]

Brent Christian bchristi at openjdk.org
Thu Jan 8 22:07:33 UTC 2026


> `RuntimeArguments.java` runs with `@requires vm.flagless`, though setting the `test.thread.factory=Virtual` system property with `-D` will still run the test.
> 
> The test spawns java processes, checking for particular, exact sets of runtime options (hence, `vm.flagless`). It is not expecting to find `-Dtest.thread.factory=Virtual`.
> 
> It doesn't seem important that this test be run with the virtual thread factory. The suggestion of adding this test to `ProblemList-Virtual.txt`  seems reasonable. (It would be a long term resident of the problem list, which is perhaps a bit strange.)
> 
> Alternative courses of action:
> * Teach the test itself to artificially pass in the presence of `-D` options.
> * Enhance the test so it knows how to expect `-D` options; offhand that doesn't seem worth it.
> 
> Update:
> The bots don't like having the "current" bugid present in the problem list. I have updated the bugid in the PL to 8309303 (when the `VM_OPTIONS` constant was added to the test) - a bit disingenuous. If we're not happy with this, I guess a new issue could be filed ("RuntimeArguments.java doesn't account for -D system properties") to use in the problem list.

Brent Christian has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - use @requires test.thread.factory instead of problem listing
 - Merge branch 'master' into probList
 - Change ProblemList bugid to 8309303
 - add VM/RuntimeArguments.java to ProblemList-Virtual.txt

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28935/files
  - new: https://git.openjdk.org/jdk/pull/28935/files/2483e66e..56651e24

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28935&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28935&range=01-02

  Stats: 26731 lines in 2591 files changed: 7154 ins; 4458 del; 15119 mod
  Patch: https://git.openjdk.org/jdk/pull/28935.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28935/head:pull/28935

PR: https://git.openjdk.org/jdk/pull/28935


More information about the core-libs-dev mailing list