RFR: 8364182: Add jcmd VM.properties command [v3]
Larry Cable
duke at openjdk.org
Thu Jan 8 22:11:18 UTC 2026
On Thu, 8 Jan 2026 21:02:37 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> Kieran Farrell has updated the pull request incrementally with one additional commit since the last revision:
>>
>> rm unused code
>
> src/hotspot/share/services/attachListener.cpp line 308:
>
>> 306: }
>> 307:
>> 308: // Implementation of "properties -security" command.
>
> We don't need this: the attach API provides some basic commands, but most of the time we use the "jcmd" attach api command, which runs a DiagnosticCommand. That's how we attach and run VM.properties etc...
>
> This makes your life easier, we don't need serializeSecurityPropertiesToByteArray(), just updated DCmd and register_DCMDFactory lines.
> (you'll need to merge in the later repo changes and resolve the register_DCMDFactory changes)
I agree, this functionality should probably be added to the existing VM.system_properties jcmd as an option (if necessary)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29124#discussion_r2674071763
More information about the core-libs-dev
mailing list