RFR: 8374219: Fix issues in jpackage's Executor class [v5]
Alexey Semenyuk
asemenyuk at openjdk.org
Fri Jan 9 03:48:24 UTC 2026
> - Move code shared between jpackage's Executor and jpackage's test lib Executor into `jdk.jpackage.internal.util.CommandOutputControl` class using the latter one as the baseline for the new class; [CommandOutputControl class javadoc](https://alexeysemenyukoracle.github.io/jpackage-javadoc/jdk.jpackage/jdk/jpackage/internal/util/CommandOutputControl.html).
> - Place "execute with retries" logic into `jdk.jpackage.internal.util.RetryExecutor` class and use it from both jpackage and jpackage's test lib. Use `jdk.jpackage.internal.RetryExecutor` class as the baseline.
> - Add `ObjectFactory`, `ExecutorFactory`, and `RetryExecutorFactory` interfaces to the "jdk.jpackage.internal" package. They enable the use of command mocks with jpackage.
> - Add `jdk.jpackage.test.mock` package. It facilitates creating command mocks. Use it to test LibProvidersLookup, LinuxSystemEnvironment, LinuxPackageArch, MacDmgSystemEnvironment, and MacDmgPackager classes.
>
> Supplementary changes:
> - Make `jdk.jpackage.internal.SystemEnvironment` and all implementing classes package private
Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
JPackageCommand: add a comment to the new withToolProvider()
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28733/files
- new: https://git.openjdk.org/jdk/pull/28733/files/538ed989..01c870f9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28733&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28733&range=03-04
Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/28733.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28733/head:pull/28733
PR: https://git.openjdk.org/jdk/pull/28733
More information about the core-libs-dev
mailing list