RFR: 8375054: Removed "signed" property from jpackage app image file
Alexey Semenyuk
asemenyuk at openjdk.org
Mon Jan 12 17:41:20 UTC 2026
$subj
Additionally:
- Validate that the value of the "--app-image" option on macOS is a valid macOS bundle, and if it is not, exit with a new "error.parameter-not-mac-bundle" error.
- Read stdout of "/usr/bin/codesign" and "/usr/sbin/spctl" commands outputing plist XML as binary, and not as text.
-------------
Commit messages:
- Fix a bug revealed by LicenseTest.java and AppImagePackageTest.java test failures
- ErrorTest: add a test case for a new "error.parameter-not-mac-bundle" error
- Remove the "signed" property from the app image file; MacHelper: fix readPList() to make it read binary output of commands that write plist xml in stdout; MacSignVerify: fix findEntitlements() to save binary output for using as input for MacHelper.readPList()
- Check that the value of the "--app-image" option is a valid macOS bundle and not an any directory
- MacBundle: move the class to shared code to use in the cli package and in the test code. Remove fromAppImageLayout() - it can't be used in the test code. Remove isSigned() - it is broken; MacPackagingPipeline: follow-up MacBundle changes, implement isSigned(MacBundle) method properly; MacFromOptions: use MacPackagingPipeline.isSigned()
- OptionSpecBuilder: support configuring cooked validator, expose createValidator()
- Validator: add or() method; simplify and()
- MacSignVerify: minor
Changes: https://git.openjdk.org/jdk/pull/29173/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29173&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8375054
Stats: 627 lines in 21 files changed: 371 ins; 182 del; 74 mod
Patch: https://git.openjdk.org/jdk/pull/29173.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29173/head:pull/29173
PR: https://git.openjdk.org/jdk/pull/29173
More information about the core-libs-dev
mailing list