RFR: 8373913: Refactor serialization tests to use JUnit [v3]
Alan Bateman
alanb at openjdk.org
Tue Jan 13 08:32:42 UTC 2026
On Mon, 12 Jan 2026 19:55:21 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> test/jdk/java/io/Serializable/serialFilter/CheckArrayTest.java line 55:
>>
>>> 53: * The filterCheck must be resilent to an InputStream not being available (only the subclass knows).
>>> 54: */
>>> 55: @TestInstance(TestInstance.Lifecycle.PER_CLASS)
>>
>> Looks like 9 other tests are using PER_CLASS, is that because of setup methods and method sources that are instance rather than static methods?
>
> The helpful conversion tool added PER_CLASS, I assume due to the source methods were instance method. Use of PER_CLASS does not seem to be discouraged.
If the test were written afresh as a JUnit test then I assume the method sources would be static methods that return a Stream of arguments. I didn't know it was a tool that was adding PER_CLASS, in which case I assume okay to do another cleanup pass for issues like this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2685378716
More information about the core-libs-dev
mailing list