RFR: 8291986: ProcessBuilder.redirectErrorStream(true) leaves error stream available [v2]
Roger Riggs
rriggs at openjdk.org
Tue Jan 13 17:48:50 UTC 2026
On Tue, 13 Jan 2026 17:06:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Refactored invocation of `lsof` to not use pipes for I/O, using files instead.
>> It removes the possibility of side effects that might affect the checking of pipe usage.
>
> test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java line 54:
>
>> 52: * @requires os.family == "mac" | (os.family == "linux" & !vm.musl)
>> 53: * @summary File descriptor leak detection with ProcessBuilder.startPipeline
>> 54: * @run junit/othervm -Xint PipelineLeaksFD
>
> Is there something in this test (or even `java.lang.Process`) that makes running this test in interpreted mode a necessity?
There was some question when the test was first introduced about failures due to races.
I'll remove that extra run and re-test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29143#discussion_r2687448066
More information about the core-libs-dev
mailing list