RFR: 8356684: jpackage error messages are not helpful [v2]
Alexander Matveev
almatvee at openjdk.org
Wed Jan 14 02:22:10 UTC 2026
On Wed, 14 Jan 2026 01:24:03 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> If the output of an external command execution results in a fatal error, jpackage will print the command line of the external command. In quiet mode (without "--vrebose"), it will also print the command's output.
>>
>> E.g. (unit test output):
>>
>> jpackage --input MainTest\testFailedCommandOutput\input --dest MainTest\testFailedCommandOutput\output --name FailedCommandOutputMainTest --type app-image --main-jar hello.jar --main-class Hello --win-console
>> Error: Unexpected exit code 17 from executing the command jlink-mock --output MainTest\testFailedCommandOutput\output\FailedCommandOutputMainTest\runtime --module-path runtime\jmods --add-modules java.base,jdk.xml.dom,jdk.zipfs --strip-native-commands --strip-debug --no-man-pages --no-header-files
>> Command output:
>> It
>> fell
>> apart
>
> Alexey Semenyuk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>
> - Update copyright year
> - CommandOutputControlTest: improve coverage
Looks good with minor typo issue.
src/jdk.jpackage/share/classes/jdk/jpackage/internal/Executor.java line 236:
> 234: }
> 235:
> 236: return ExecutableAttributesWithCapturedOutput.augmenResultWithOutput(result, printableOutput);
`augmen` -> 'augment'
-------------
PR Review: https://git.openjdk.org/jdk/pull/29197#pullrequestreview-3658491787
PR Review Comment: https://git.openjdk.org/jdk/pull/29197#discussion_r2688620920
More information about the core-libs-dev
mailing list