RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v25]

[Doug Lea]

On Tue, 13 Jan 2026 15:57:34 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix missing undo
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2591:
> 
>> 2589:                 unlockRunState();
>> 2590:             }
>> 2591:                 ForkJoinTask<?>[] a;
> 
> `a` is not used

Thanks for finding remnants of incomplete undo/redos!

> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2593:
> 
>> 2591:                 ForkJoinTask<?>[] a;
>> 2592:             if (q != null && (lock = q.tryLockPhase()) != 1) {
>> 2593:                  int unlock = lock + NEXTIDLE;
> 
> Suggestion:
> 
>                 int unlock = lock + NEXTIDLE;

Same

> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2604:
> 
>> 2602:         throw new RejectedExecutionException();
>> 2603:     }
>> 2604:     private void poolSubmit(ForkJoinTask<?> task, boolean signalIfEmpty) {
> 
> Suggestion:
> 
> 
>     private void poolSubmit(ForkJoinTask<?> task, boolean signalIfEmpty) {

And another one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2690252073
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2690253141
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2690253986