RFR: 8374215: [macos] Clean and fix "lic_template.plist" to correctly work with multiple languages
Alexander Matveev
almatvee at openjdk.org
Wed Jan 14 16:35:59 UTC 2026
On Tue, 23 Dec 2025 03:58:32 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> - Fixed plist file so translation works. It did not worked before.
>> - All strings which needs translations moved to .properties files.
>> - Added translated strings, since it is required to have all of them. We cannot have English strings in localized files, since different charset is required for each language.
>> - I tested all translations.
>> - Adding same license text for all translations is required.
>> - See JBS for screenshot of dialog. It is same except it now has drop down box with 4 languages we support. There are no way to remove it once translations implemented correctly in plist file.
>> - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are no alternative for it.
>
> I don't support complicating jpackage with the warning.
>
> When `hdiutil udifrez` stops working, jpackage will start failing:
> https://github.com/openjdk/jdk/blob/ecb42341a94326b1ee85ddd7b9ebadce8c952b99/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgPackager.java#L417
>
> We don't need anything extra.
@alexeysemenyukoracle Please review it again. I updated description with all changes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3750426044
More information about the core-libs-dev
mailing list