RFR: 8374215: [macos] Clean and fix "lic_template.plist" to correctly work with multiple languages [v4]
Alexander Matveev
almatvee at openjdk.org
Thu Jan 15 00:46:56 UTC 2026
On Wed, 14 Jan 2026 04:55:05 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
>> - Fixed plist file so translation works. It did not worked before.
>> - All strings which needs translations moved to .properties files.
>> - Added translated strings, since it is required to have all of them. We cannot have English strings in localized files, since different charset is required for each language.
>> - I tested all translations.
>> - Adding same license text for all translations is required.
>> - See JBS for screenshot of dialog. It is same except it now has drop down box with 4 languages we support. There are no way to remove it once translations implemented correctly in plist file.
>> - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are no alternative for it.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>
> Added missing import from merge
8374215: [macos] Clean "lic_template.plist" [v3]
- Moved DMG license related code to `MacDmgLicense`.
- Added DMG license verification code to `LicenseTest.java`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3752346622
More information about the core-libs-dev
mailing list