RFR: 8375242: [macos] Improve jpackage signing coverage

[Alexander Matveev]

On Tue, 13 Jan 2026 18:23:00 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Refactor signing tests covering gaps listed in the [CR description](https://bugs.openjdk.org/browse/JDK-8375242).
> 
> Old test signatures:
> 
> SigningAppImageTest.test(true, true, ASCII_INDEX)
> SigningAppImageTest.test(true, true, UNICODE_INDEX)
> SigningAppImageTest.test(true, false, UNICODE_INDEX)
> SigningAppImageTest.test(false, true, INVALID_INDEX)
> 
> SigningAppImageTwoStepsTest.test(true, true)
> SigningAppImageTwoStepsTest.test(true, false)
> SigningAppImageTwoStepsTest.test(false, true)
> 
> SigningPackageTest.test(true, true, true, ASCII_INDEX)
> SigningPackageTest.test(true, true, true, UNICODE_INDEX)
> SigningPackageTest.test(false, true, true, UNICODE_INDEX)
> SigningPackageTest.test(false, true, false, UNICODE_INDEX)
> SigningPackageTest.test(false, false, true, UNICODE_INDEX)
> 
> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}; {MAC_DMG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test({MAC_DMG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]})
> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}; {MAC_DMG={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-installer-sign-identity: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test({MAC_DMG={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-installer-sign-identity: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]})
> 
> SigningRuntimeImagePackageTest.test(true, INVALID_INDEX,...

Looks good with some questions/comments.

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line 295:

> 293:     }
> 294: 
> 295:     public JPackageCommand setFakeRuntime() {

I updated this function in https://github.com/openjdk/jdk/pull/29260 to include version for release file. Do you have suggestion on how resolve this conflict? I think we need ability to pass additional arguments to `setFakeRuntime(String version)`. In this case we will have `createInputRuntimeImage(RuntimeImageType role, String version)`, but it will not be clear to which runtime version should be applied.

test/jdk/tools/jpackage/macosx/SigningBase.java line 2:

> 1: /*
> 2:  * Copyright (c) 2019, 2026, Oracle and/or its affiliates. All rights reserved.

Do you know why moving this file is not recorded as rename?

test/jdk/tools/jpackage/macosx/SigningPackageTwoStepTest.java line 199:

> 197:                 JPackageStringBundle.MAIN.cannedFormattedString("warning.unsigned.app.image", "pkg");
> 198: 
> 199:         // The warnings are mutual exclusive

`mutual` -> `mutually`

-------------

PR Review: https://git.openjdk.org/jdk/pull/29205#pullrequestreview-3668410198
PR Review Comment: https://git.openjdk.org/jdk/pull/29205#discussion_r2696588745
PR Review Comment: https://git.openjdk.org/jdk/pull/29205#discussion_r2696666005
PR Review Comment: https://git.openjdk.org/jdk/pull/29205#discussion_r2696675195