RFR: 8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified [v2]
Alexander Matveev
almatvee at openjdk.org
Fri Jan 16 04:36:16 UTC 2026
On Fri, 16 Jan 2026 04:27:11 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> I added it to reduce to 3 components due to `MacApplicationBuilder.validateAppVersion()`. Mac packages does not require 3 component version, so maybe this logic by normalizing application version should change.
>
> Sorry, I still don't get it. jpackage doesn't run normalization on the version it reads from the "release" file, right? Why does the testing code do it?
jpackage will normalize macOS version read from release file to 3 components and Windows to 4 components. See `MacFromOptions` and `WinApplication`. Normalization is done for application and package builder just use it from application. macOS limits application version CFBundleVersion to 3 components, thus to align with Windows it was limited to 3. Testing code needs to do same.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2696869000
More information about the core-libs-dev
mailing list