RFR: 8375242: [macos] Improve jpackage signing coverage [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Fri Jan 16 04:55:01 UTC 2026
> Refactor signing tests covering gaps listed in the [CR description](https://bugs.openjdk.org/browse/JDK-8375242).
>
> Old test signatures:
>
> SigningAppImageTest.test(true, true, ASCII_INDEX)
> SigningAppImageTest.test(true, true, UNICODE_INDEX)
> SigningAppImageTest.test(true, false, UNICODE_INDEX)
> SigningAppImageTest.test(false, true, INVALID_INDEX)
>
> SigningAppImageTwoStepsTest.test(true, true)
> SigningAppImageTwoStepsTest.test(true, false)
> SigningAppImageTwoStepsTest.test(false, true)
>
> SigningPackageTest.test(true, true, true, ASCII_INDEX)
> SigningPackageTest.test(true, true, true, UNICODE_INDEX)
> SigningPackageTest.test(false, true, true, UNICODE_INDEX)
> SigningPackageTest.test(false, true, false, UNICODE_INDEX)
> SigningPackageTest.test(false, false, true, UNICODE_INDEX)
>
> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}; {MAC_DMG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test({MAC_DMG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]})
> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}; {MAC_DMG={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-installer-sign-identity: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test({MAC_DMG={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-installer-sign-identity: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]})
>
> SigningRuntimeImagePackageTest.test(true, INVALID_INDEX,...
Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
SigningPackageTwoStepTest: fix a typo in the comment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29205/files
- new: https://git.openjdk.org/jdk/pull/29205/files/f55906bc..8224f5e5
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29205&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29205&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/29205.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29205/head:pull/29205
PR: https://git.openjdk.org/jdk/pull/29205
More information about the core-libs-dev
mailing list