RFR: 8375242: [macos] Improve jpackage signing coverage [v3]

[Alexander Matveev]

On Fri, 16 Jan 2026 05:06:39 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Refactor signing tests covering gaps listed in the [CR description](https://bugs.openjdk.org/browse/JDK-8375242).
>> 
>> Old test signatures:
>> 
>> SigningAppImageTest.test(true, true, ASCII_INDEX)
>> SigningAppImageTest.test(true, true, UNICODE_INDEX)
>> SigningAppImageTest.test(true, false, UNICODE_INDEX)
>> SigningAppImageTest.test(false, true, INVALID_INDEX)
>> 
>> SigningAppImageTwoStepsTest.test(true, true)
>> SigningAppImageTwoStepsTest.test(true, false)
>> SigningAppImageTwoStepsTest.test(false, true)
>> 
>> SigningPackageTest.test(true, true, true, ASCII_INDEX)
>> SigningPackageTest.test(true, true, true, UNICODE_INDEX)
>> SigningPackageTest.test(false, true, true, UNICODE_INDEX)
>> SigningPackageTest.test(false, true, false, UNICODE_INDEX)
>> SigningPackageTest.test(false, false, true, UNICODE_INDEX)
>> 
>> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}; {MAC_DMG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
>> SigningPackageTwoStepTest.test({MAC_DMG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
>> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]})
>> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}; {MAC_DMG={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-installer-sign-identity: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
>> SigningPackageTwoStepTest.test({MAC_DMG={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]}, MAC_PKG={--mac-installer-sign-identity: CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, ...]}})
>> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, ...]})
>> 
>> Si...
>
> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "SigningBase: move to the "base""
>    
>    This reverts commit b50c717d83096b67ff530d90715d87fa0d9ade20.
>  - SigningBase: move to the "base"

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29205#pullrequestreview-3672513135