RFR: 8371955: Support AVX10 floating point comparison instructions [v5]

Mohamed Issa missa at openjdk.org
Mon Jan 19 23:15:06 UTC 2026


On Fri, 16 Jan 2026 17:25:08 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Mohamed Issa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary CMOV blocks and adjust predicates involving APX and AVX10.2
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 7357:
> 
>> 7355: }
>> 7356: 
>> 7357: void Assembler::ucomxss(XMMRegister dst, Address src) {
> 
> ucomxss should be named as vucomxss.
> ucomxsd should be named as vucomxsd.

I re-named them.

> src/hotspot/cpu/x86/x86.ad line 1703:
> 
>> 1701: static void emit_cmpfp3(MacroAssembler* masm, Register dst) {
>> 1702:   // If any floating point comparison instruction is used, unordered case always triggers jump
>> 1703:   // For below condition, CF=1 is true when at least one input is NaN
> 
> // for
> lowercase f in for.

This is modified now.

> test/hotspot/jtreg/compiler/c2/irTests/CMoveLConstants.java line 64:
> 
>> 62:     @IR(counts = {IRNode.X86_CMOVEL_IMM01UCFE, "1"},
>> 63:         applyIfPlatform = {"x64", "true"},
>> 64:         applyIfCPUFeature = {"apx_f", "true"},
> 
> Need to include avx10_2 check here as well.

I added the avx10_2 checks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28337#discussion_r2706285643
PR Review Comment: https://git.openjdk.org/jdk/pull/28337#discussion_r2706285351
PR Review Comment: https://git.openjdk.org/jdk/pull/28337#discussion_r2706286308


More information about the core-libs-dev mailing list