RFR: 8373924: Dangling pointer in ImageDecompressor::image_decompressor_close of imageDecompressor.cpp [v3]
Eirik Bjørsnøs
eirbjo at openjdk.org
Sat Jan 24 20:20:50 UTC 2026
On Fri, 23 Jan 2026 18:56:55 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> src/java.base/share/native/libjimage/imageDecompressor.cpp line 96:
>>
>>> 94: _decompressors = NULL;
>>> 95: _decompressors_num = 0;
>>> 96: }
>>
>> What would you think about removing it? Its dead code and not tested.
>
> We can do that too since it's by design to have same lifespan as the process. I'll run some more tests to confirm removing is safe.
>
> The close can be added when the requirements change.
Consider updating the issue / PR title to reflect the removal instead of fixing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29371#discussion_r2724573245
More information about the core-libs-dev
mailing list