RFR: 8376271: ZipFile comment confusingly refers to "native" ZIP file implementation
Jaikiran Pai
jpai at openjdk.org
Mon Jan 26 16:38:51 UTC 2026
On Sun, 25 Jan 2026 10:57:52 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this comment-only PR which updates a field comment referring to `ZipFile.Source` as "native".
>
> ZipFile has not used a native implementation since Java 8, so this comment may be confusing.
>
> The comment seems to have been introduced in 2017 as part of JDK-8185582 when ZipFile was updated to use Cleaners instead of finalizers. (The use of quotation marks in "native" may have meant to indicate that this is "not really native", but I still find it confusing).
>
> While visiting this comment, I also made an attempt to make the leading sentence of this field comment less mysterious.
>
> Comment only, trivial, low risk: `noreg-trivial`
This looks good to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29401#pullrequestreview-3706911928
More information about the core-libs-dev
mailing list