RFR: 8375285: Port fdlibm asinh to Java [v2]

[Anton Artemov]

On Mon, 26 Jan 2026 20:36:09 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8375285: Addressed the reviewer's comments, fixed year in the copyright notice.
>
> src/java.base/share/classes/java/lang/FdLibm.java line 3544:
> 
>> 3542:             hx = __HI(x);
>> 3543:             ix = hx & 0x7fffffff;
>> 3544:             if(ix >= 0x7ff00000) {
> 
> Suggestion:
> 
>             if (ix >= 0x7ff00000) {

Addressed.

> src/java.base/share/classes/java/lang/FdLibm.java line 3548:
> 
>> 3546:             }
>> 3547:             if(ix < 0x3e300000) {                   // |x| < 2**-28
>> 3548:                 if(huge + x > 1.0) {
> 
> Suggestion:
> 
>             if (ix < 0x3e300000) {                   // |x| < 2**-28
>                 if (huge + x > 1.0) {

Addressed.

> src/java.base/share/classes/java/lang/FdLibm.java line 3552:
> 
>> 3550:                 }
>> 3551:             }
>> 3552:             if(ix > 0x41b00000) {                   // |x| > 2**28
> 
> Suggestion:
> 
>             if (ix > 0x41b00000) {                   // |x| > 2**28

Addressed.

> test/jdk/java/lang/Math/HyperbolicTests.java line 1535:
> 
>> 1533: 
>> 1534: 
>> 1535:         for(int i = 0; i < testCases.length; i++) {
> 
> Suggestion:
> 
>         for (int i = 0; i < testCases.length; i++) {

Addressed.

> test/jdk/java/lang/Math/HyperbolicTests.java line 1544:
> 
>> 1542: 
>> 1543: 
>> 1544:         for(double nan : Tests.NaNs) {
> 
> Suggestion:
> 
>         for (double nan : Tests.NaNs) {

Addressed.

> test/jdk/java/lang/Math/HyperbolicTests.java line 1559:
> 
>> 1557: 
>> 1558: 
>> 1559:         for(int i = 0; i < specialTestCases.length; i++) {
> 
> Suggestion:
> 
>         for (int i = 0; i < specialTestCases.length; i++) {

Addressed.

> test/jdk/java/lang/Math/HyperbolicTests.java line 1572:
> 
>> 1570:         // double significand.
>> 1571: 
>> 1572:         for(int i = DoubleConsts.MIN_SUB_EXPONENT; i < -27; i++) {
> 
> Suggestion:
> 
>         for (int i = DoubleConsts.MIN_SUB_EXPONENT; i < -27; i++) {

Addressed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2730972734
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2730972447
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2730972291
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2730973712
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2730973465
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2730973218
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2730972916