Integrated: 8376271: ZipFile comment confusingly refers to "native" ZIP file implementation
Eirik Bjørsnøs
eirbjo at openjdk.org
Tue Jan 27 10:32:07 UTC 2026
On Sun, 25 Jan 2026 10:57:52 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this comment-only PR which updates a field comment referring to `ZipFile.Source` as "native".
>
> ZipFile has not used a native implementation since Java 8, so this comment may be confusing.
>
> The comment seems to have been introduced in 2017 as part of JDK-8185582 when ZipFile was updated to use Cleaners instead of finalizers. (The use of quotation marks in "native" may have meant to indicate that this is "not really native", but I still find it confusing).
>
> While visiting this comment, I also made an attempt to make the leading sentence of this field comment less mysterious.
>
> Comment only, trivial, low risk: `noreg-trivial`
This pull request has now been integrated.
Changeset: 4ff5f3a8
Author: Eirik Bjørsnøs <eirbjo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/4ff5f3a8c0910e9ed9d77586bd692c469bdf3460
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
8376271: ZipFile comment confusingly refers to "native" ZIP file implementation
Reviewed-by: jpai
-------------
PR: https://git.openjdk.org/jdk/pull/29401
More information about the core-libs-dev
mailing list