RFR: 8375433: jar should validate automatic module names [v2]
Christian Stein
cstein at openjdk.org
Tue Jan 27 14:24:36 UTC 2026
On Tue, 27 Jan 2026 14:00:43 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> The `this.md` field is initialized (by `checkModuleDescriptor(MODULE_INFO);` from within the constructor) to the "base" compiled module descriptor. It also includes this comment:
>>
>>> ```
>>> // Initialize the base md if it's not yet. A "base" md can be either the
>>> // root module-info.class or the first versioned module-info.class
>>> ```
>>
>> With that in place, and the consistency checks being performed in `checkModuleDescriptor(MODULE_INFO);`, we are good.
>
> I mean for cases where there are multiple module-info.class files. The automatic module name check only checks the first one, right?
Right.
> I mean for cases where there are multiple `module-info.class` files.
Which are checked for a single name separately. Thus, comparing an automatic module name with the name from the first compiled module is sufficient.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29316#discussion_r2732246538
More information about the core-libs-dev
mailing list