RFR: 8376038: Refactor java/sql tests to use JUnit [v3]
Justin Lu
jlu at openjdk.org
Wed Jan 28 23:23:26 UTC 2026
> Please review this PR which converts the JDBC TestNG tests to use JUnit.
>
> This is mainly done using the automated tool in https://github.com/openjdk/jdk/commit/0cec3097aec02e72ccb6ebbf0b2b046220578d1b, with some manual follow up commits. The testng folder is migrated to junit with the TEST.properties updated as well. Most changes are annotation updates and switching from testNG imports to JUnit. I decided to simplify cases of `BaseTest.trueFalse()` to use booleans in a `ValueSource` directly in https://github.com/openjdk/jdk/commit/757e7966666d39748db2912b32ccf8b1df18bd62.
>
> Framework test stats before:
> 680 = 680 TestNG + 0 JUnit
>
> Framework test stats after:
> 680 = 0 TestNG + 680 JUnit
Justin Lu has updated the pull request incrementally with six additional commits since the last revision:
- TEST.properties eof newlines
- java/sql tests no longer require junit subdir
- Move drivermanager tests together
- javax/sql tests no longer require junit subdir
- Move resourcebundle tests together
- Migrate the javax/sql/rowset/serial/ tests to JUnit
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29354/files
- new: https://git.openjdk.org/jdk/pull/29354/files/06098254..e80ad61a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29354&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29354&range=01-02
Stats: 224 lines in 108 files changed: 50 ins; 143 del; 31 mod
Patch: https://git.openjdk.org/jdk/pull/29354.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29354/head:pull/29354
PR: https://git.openjdk.org/jdk/pull/29354
More information about the core-libs-dev
mailing list