RFR: 8376185: NoSuchFieldError thrown after a record with type annotation retransformed [v2]
Jean-Philippe Bempel
jpbempel at openjdk.org
Fri Jan 30 09:09:58 UTC 2026
On Fri, 30 Jan 2026 08:24:22 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add copyright headers
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1477:
>
>> 1475: if (res != JVMTI_ERROR_NONE) {
>> 1476: return res;
>> 1477: }
>
> Pending exception need to be processed and cleared below (see lines: 1478-1487).
@sspitsyn I am not sure to follow your comment.
In the case of invalid structure, no exception was pending and therefore the method `load_new_class_versions` returns no error.
if `merge_cp_and_rewrite` returns anything else than `JVMTI_ERROR_NONE` it should be propagated.
Now, if you want to process pending exception first I can move the check result after, but for example the call above to `compare_and_normalize_class_versions` is done like this also
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29445#discussion_r2745309806
More information about the core-libs-dev
mailing list