<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
Hi Michael,<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Sep 16, 2022, at 6:19 PM, Michael Hall <<a href="mailto:mik3hall@gmail.com" class="">mik3hall@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<br class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On Sep 16, 2022, at 6:02 PM, Alexander Matveev <<a href="mailto:almatvee@openjdk.org" class="">almatvee@openjdk.org</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Problem
 is that [JDK-8286850](</span><a href="https://bugs.openjdk.org/browse/JDK-8286850" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://bugs.openjdk.org/browse/JDK-8286850</a><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">)
 never set correct value in .jpackage.xml to mark image as signed. [JDK-8289030](</span><a href="https://bugs.openjdk.org/browse/JDK-8289030" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://bugs.openjdk.org/browse/JDK-8289030</a><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">)
 reads this value to check if we can add per-user and system wide configuration to packaged app. Fixed by setting correct value in .jpackage.xml when we signing predefine application image.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
</div>
</blockquote>
</div>
<br class="">
<div class="">Alexander,</div>
<div class=""><br class="">
</div>
<div class="">I think I figured out how to include PR’s in my build and this appears good.</div>
<div class=""><br class="">
</div>
<div class="">codesign -v --verbose=4 "/Volumes/BlackJack Blastoff_Unsigned/BlackJack Blastoff_Unsigned.app"<br class="">
/Volumes/BlackJack Blastoff_Unsigned/BlackJack Blastoff_Unsigned.app: valid on disk<br class="">
/Volumes/BlackJack Blastoff_Unsigned/BlackJack Blastoff_Unsigned.app: satisfies its Designated Requirement<br class="">
<br class="">
</div>
<div class="">This was new…</div>
<div class="">Warning: Support for per-user configuration of the installed application will not be supported due to missing "BlackJack Blastoff_Unsigned.app/Contents/app/.package" in predefined signed application image.</div>
<div class=""><br class="">
</div>
<div class="">I’m not quite sure what it’s saying but it doesn’t seem to impact what I’m doing.</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>This warning means that support for per-user configuration of the installed application will be disabled. We added support for per-user configuration with <a href="https://bugs.openjdk.org/browse/JDK-8250950" class="">https://bugs.openjdk.org/browse/JDK-8250950</a> (Allow
 per-user and system wide configuration of a jpackaged app).</div>
<div><br class="">
</div>
<div>Thanks,</div>
<div>Alexander</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Mike</div>
<div class=""><br class="">
</div>
<div class="">FWIW, I ran into </div>
<div class="">[macos] cmstypes.c fails compilation with Xcode13.3</div>
<div class=""><a href="https://bugs.openjdk.org/browse/JDK-8283221" class="">https://bugs.openjdk.org/browse/JDK-8283221</a></div>
<div class=""><br class="">
</div>
<div class="">Adding this which I noticed in the source…</div>
<div class="">cmsUNUSED_PARAMETER(SizeOfTag);    // mjh</div>
<div class=""><br class="">
</div>
<div class="">To the two erroring methods…</div>
<div class="">~/Documents/GitHub/jdk/build/macosx-x86_64-server-release/build.log:179: /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132: error: parameter 'SizeOfTag' set but not used [-Werror,-Wunused-but-set-parameter]<br class="">
~/Documents/GitHub/jdk/build/macosx-x86_64-server-release/build.log:182: /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:5137:125: error: parameter 'SizeOfTag' set but not used [-Werror,-Wunused-but-set-parameter]<br class="">
<br class="">
</div>
<div class=""><br class="">
</div>
<div class="">Seemed a fix. I could build.</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</body>
</html>