<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
HI Eirik<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Feb 23, 2023, at 7:43 AM, Eirik Bjørsnøs <<a href="mailto:eirbjo@gmail.com" class="">eirbjo@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">Hi,<br class="">
<div class=""><br class="">
</div>
<div class="">While writing various ZIP related tests, I noticed a discrepancy in the treatment of invalid CRC values:</div>
<div class=""><br class="">
</div>
<div class="">While ZipInputStream rejects invalid CRC values when consuming streams, ZipFile and ZipFileSystem do not.</div>
<div class=""><br class="">
</div>
<div class="">While this is inconsistent, it is perhaps not a bug we want to fix?</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
I believe it is intentional. Alan, Martin B, do you recall the history?<br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class=""><br class="">
</div>
<div class="">In any case, it could perhaps be good to have better test coverage in this area. Here's a test which validates the current behaviour of ZIS, ZF and ZFS:</div>
<div class=""><br class="">
</div>
<div class=""><a href="https://github.com/openjdk/jdk/compare/master...eirbjo:jdk:zip-invalid-crc" class="">https://github.com/openjdk/jdk/compare/master...eirbjo:jdk:zip-invalid-crc</a><br class="">
</div>
</div>
</div>
</blockquote>
<div><br class="">
</div>
I will take a look next week</div>
<div><br class="">
</div>
<div>Thank you for your efforts in this area</div>
<div><br class="">
</div>
<div>Best</div>
<div>Lance<br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class=""><br class="">
</div>
<div class="">Any thoughts?</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Eirik.</div>
<div class=""><br class="">
</div>
<div class=""> <br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
<div class=""><span><img apple-inline="yes" id="A9579DF2-0BEA-4AA2-8ABB-987E81D235EC" src="cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home" class=""></span>
<div dir="auto" style="font-family: Helvetica; font-size: 18px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<div><br class="Apple-interchange-newline">
<br class="Apple-interchange-newline">
<br class="Apple-interchange-newline">
<br class="">
<br class="">
<br class="">
Lance Andersen | Principal Member of Technical Staff | +1.781.442.2037</div>
<div>Oracle Java Engineering <br class="">
1 Network Drive <br class="">
Burlington, MA 01803<br class="">
<a href="mailto:Lance.Andersen@oracle.com" class="">Lance.Andersen@oracle.com</a></div>
</div>
<br class="Apple-interchange-newline" style="font-family: Helvetica; font-size: 18px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">
<br class="Apple-interchange-newline" style="font-family: Helvetica; font-size: 18px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);">
</div>
<br class="">
</body>
</html>