<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body dir="auto">
Morning
<div><br>
</div>
<div>I will take care of this for you <br>
<br>
<div dir="ltr">--
<div><br>
<div>
<div dir="auto" class="" style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">
<div><span style="background-color: rgba(255, 255, 255, 0);">Lance Andersen | Principal Member of Technical Staff | <span dir="ltr">+1.781.442.2037</span></span></div>
<div><span style="background-color: rgba(255, 255, 255, 0);">Oracle Java Engineering <br class="">
<span dir="ltr">1 Network Drive </span><br class="">
<span dir="ltr">Burlington, MA 01803</span><br class="">
<a href="mailto:Lance.Andersen@oracle.com" class="">Lance.Andersen@oracle.com</a></span></div>
</div>
</div>
<div><br>
</div>
Sent from my iPhone</div>
</div>
<div dir="ltr"><br>
<blockquote type="cite">On Mar 7, 2023, at 7:31 AM, Eirik Bjørsnøs <eirbjo@gmail.com> wrote:<br>
<br>
</blockquote>
</div>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>For the note then you might want to change it to "ZipEntry e = ..." because the reader see the trailing slash after dir so it is obviously a directory.</div>
</blockquote>
<div><br>
</div>
<div>That does indeed make more sense for the general case.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>Also the javadoc uses "crc-32" rather than "crc" should we should keep that consistent if we can.<br>
</div>
</blockquote>
<div><br>
</div>
<div>I opted for the uppercase "CRC-32" here since that seems to be used in the majority of cases when referring to this checksum.</div>
<div><br>
</div>
<div>I have pushed the updates to the PR and the updated the suggested CSR.</div>
<div><br>
</div>
<div>I would appreciate help from someone to file an issue and CSR in JBS. Should be mostly copy paste from the PR if I got it right.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Eirik. </div>
</div>
</div>
</div>
</blockquote>
</div>
</body>
</html>