
<html><head>

<meta http-equiv="Content-Type" content="text/html; charset=utf-8">

  </head>

  <body>

    On 07/03/2023 08:21, Eirik Bjørsnøs wrote:<br>

    <blockquote type="cite" cite="mid:CA+pBWhstT6DTHfP9Q96Ve6zp6+=Aq-rqTiAy+fVSbLCyQ8Ja2Q@mail.gmail.com">

      

      <div dir="ltr">:<br>

        <div class="gmail_quote">

          <div><br>

          </div>

          <div>Seems we reached consensus that the right thing to do

            here is to add an `@apiNote`</div>

          <div><br>

          </div>

          <div>Here's a draft PR with a suggested CSR:</div>

          <div><br>

          </div>

          <div><a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/12899__;!!ACWV5N9M2RV99hQ!JHKVw9-_twtqnwpDZOujHDa0DGd3b9cZnWu0dIC3RjeLReueGxSik19nbAJsNQg05qvwbGKnqEQXFfs$" moz-do-not-send="true">https://github.com/openjdk/jdk/pull/12899</a><br>

          </div>

          <div><br>

          </div>

        </div>

      </div>

    </blockquote>

    <br>

    Yes, I think an apiNote is the best thing to do here.<br>

    <br>

    For the note then you might want to change it to "ZipEntry e = ..."

    because the reader see the trailing slash after dir so it is

    obviously a directory. Also the javadoc uses "crc-32" rather than

    "crc" should we should keep that consistent if we can.<br>

    <br>

    -Alan<br>

    <br>

    <br>

    <br>

  </body>

</html>