<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Sounds very reasonable.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> core-libs-dev <core-libs-dev-retn@openjdk.org> on behalf of Aleksei Ivanov <alexey.ivanov@oracle.com><br>
<b>Sent:</b> Wednesday, 24 May 2023 20:03<br>
<b>To:</b> Robin Gong <irobingong@gmail.com>; core-libs <core-libs-dev@openjdk.org><br>
<b>Subject:</b> Re: Remove unnecessary method call in PriorityBlockingQueue</font>
<div> </div>
</div>
<div>Hi Robin,<br>
<br>
This belongs in core-libs.<br>
<br>
<div class="x_moz-cite-prefix">On 24/05/2023 16:50, Robin Gong wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>Recently, I found this constructor in PriorityBlockingQueue:</div>
<div><br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px
0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
public PriorityBlockingQueue(int initialCapacity,<br>
Comparator<? super E> comparator) {<br>
if (initialCapacity < 1)<br>
throw new IllegalArgumentException();<br>
this.comparator = comparator;<br>
this.queue = new Object[Math.max(1, initialCapacity)];<br>
}</blockquote>
<div><br>
</div>
<div>I believe we could change 'Math.max(1, initialCapacity)' to 'initialCapacity'. Since initialCapacity must be greater or equal to 1.</div>
</div>
</blockquote>
<br>
It looks reasonable to me.<br>
<br>
-- <br>
Regards,<br>
Alexey<br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
<div>And also that's how PriorityQueue running.</div>
<div><br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px
0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
public PriorityQueue(int initialCapacity,<br>
Comparator<? super E> comparator) {<br>
// Note: This restriction of at least one is not actually needed,<br>
// but continues for 1.5 compatibility<br>
if (initialCapacity < 1)<br>
throw new IllegalArgumentException();<br>
this.queue = new Object[initialCapacity];<br>
this.comparator = comparator;<br>
}</blockquote>
<div><br>
</div>
<div>Best regarts,</div>
<div>Robin Gong</div>
</div>
</blockquote>
<br>
</div>
</body>
</html>