<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Hi Anthony,<br>
<br>
Go ahead a file a single bug (for the two cases).<br>
That code may have been written before Arrays.fill(...).<br>
<br>
Regards, Roger<br>
<br>
<div class="moz-cite-prefix">On 11/29/23 7:54 AM, Anthony Goubard
wrote:<br>
</div>
<blockquote type="cite" cite="mid:CANsEkGt-QvP1CUVKsmqGEhYRCRgZHrod=OcgWJRLokFXpa6RQQ@mail.gmail.com">
<div dir="ltr">Hello,<br>
<br>
Last Friday, I decided to look if there were some classes that
did unneeded array assignments (e.g. to 0 / 0.0f / null / false)
in the JDK.<br>
<br>
I've found a few places and in particular 2 places where it's
done in big for loops (looping more than 500 times). So I
thought you might be interested to know about them.<br>
<br>
<a href="https://github.com/openjdk/jdk/blob/6871a2ff1207d3ee70973b1c4ee9bd09969c185b/src/java.base/share/classes/java/text/MergeCollation.java#L72" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jdk/blob/6871a2ff1207d3ee70973b1c4ee9bd09969c185b/src/java.base/share/classes/java/text/MergeCollation.java#L72</a><br>
<a href="https://github.com/openjdk/jdk/blob/6871a2ff1207d3ee70973b1c4ee9bd09969c185b/src/java.base/share/classes/sun/text/CompactByteArray.java#L85" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jdk/blob/6871a2ff1207d3ee70973b1c4ee9bd09969c185b/src/java.base/share/classes/sun/text/CompactByteArray.java#L85</a><br>
Also for CompactByteArray, maybe it's worth checking that
defaultValue is different than 0 before entering the for loop
(Line 80)<br>
<br>
Let me know if you're interested in fixing them and if you want
me to fill 2 bugs for them in the JBS or in <a href="http://bugreport.java.com" moz-do-not-send="true">bugreport.java.com</a>.<br>
<br>
Best regards,<br>
Anthony Goubard<br>
</div>
</blockquote>
<br>
</body>
</html>